reschke commented on code in PR #111:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/111#discussion_r1434015830
##########
src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java:
##########
@@ -1148,19 +1148,26 @@ private boolean addEntry(final Map<String,
List<MapEntry>> entryMap, final Strin
*/
private Map<String, Map<String, Collection<String>>> loadAliases(final
ResourceResolver resolver) {
final Map<String, Map<String, Collection<String>>> map = new
ConcurrentHashMap<>();
- final String queryString = generateAliasQuery();
+ final String baseQueryString = generateAliasQuery();
- log.debug("start alias query: {}", queryString);
- long queryStart = System.nanoTime();
- final Iterator<Resource> i = resolver.findResources(queryString,
"JCR-SQL2");
- long queryElapsed = System.nanoTime() - queryStart;
- log.debug("end alias query; elapsed {}ms",
TimeUnit.NANOSECONDS.toMillis(queryElapsed));
+ Iterator<Resource> it;
+ try {
+ final String queryStringWithSort = baseQueryString + " AND
FIRST([sling:alias]) > '%s' ORDER BY FIRST([sling:alias])";
+ it = new PagedQueryIterator("alias", "sling:alias", resolver,
queryStringWithSort,
+ Integer.getInteger("sling.alias.pageSize", 2000));
Review Comment:
The system property was added to ease debugging and performance testing, not
to be set in practice.
I seriously doubt that adding more OSGi toggles would be helpful, but if we
did this, we should do it consistently (and maybe dissuss whether alias and
vanity path need different ones).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
