Julian, FWIW: disagreeing is not the same thing as "ignoring".
Well, you did more than just disagree. There was no followup to any of the 3 replies to explain your position. I'm not a mind reader. On Mon, Jan 22, 2024 at 1:15 AM Julian Reschke <julian.resc...@gmx.de.invalid> wrote: > On 20.01.2024 02:09, Eric Norman wrote: > > +0 for me. > > > > Though, I am still a little annoyed that you just ignored my review > > comments from > > > https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/109#pullrequestreview-1791514750 > > Eric, > > FWIW: disagreeing is not the same thing as "ignoring". This change was > urgent because it addresses a customer-visible defect (aliases broken > when more than >100K). What you raised is a stylistic issue which is not > specific to this PR, so it really ought to be addressed/discussed as > separate issue. > > Best regards, Julian >
