[
https://issues.apache.org/jira/browse/SLING-12245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17815614#comment-17815614
] Konrad Windszus edited comment on SLING-12245 at 2/8/24 10:42 AM: ------------------------------------------------------------------ This issue affects every ResourceChangeListener! I wouldn't want to implement such a logic in every implementation. Some examples: # https://github.com/apache/sling-org-apache-sling-i18n/blob/262951b8a778757df0af8495ae71f3f264b8df30/src/main/java/org/apache/sling/i18n/impl/JcrResourceBundleProvider.java#L222 # https://github.com/apache/sling-org-apache-sling-xss/blob/16bb365c0116374c2a17340242189afb8ad38cd4/src/main/java/org/apache/sling/xss/impl/XSSFilterImpl.java#L372 # https://github.com/apache/sling-org-apache-sling-scripting-sightly/blob/690a818692bd08c3f6a49e842ea530cc3e60e3ad/src/main/java/org/apache/sling/scripting/sightly/impl/engine/ResourceBackedPojoChangeMonitor.java#L75 # https://github.com/apache/sling-org-apache-sling-event/blob/94680f155e8a88ea6b8f937656bdfd9c9c6a3cea/src/main/java/org/apache/sling/event/impl/jobs/scheduling/JobSchedulerImpl.java#L564 ... was (Author: kwin): This issue affects every ResourceChangeListener! I wouldn't want to implement such a logic in every implementation. Some examples: # https://github.com/apache/sling-org-apache-sling-i18n/blob/262951b8a778757df0af8495ae71f3f264b8df30/src/main/java/org/apache/sling/i18n/impl/JcrResourceBundleProvider.java#L222 # https://github.com/apache/sling-org-apache-sling-xss/blob/16bb365c0116374c2a17340242189afb8ad38cd4/src/main/java/org/apache/sling/xss/impl/XSSFilterImpl.java#L372 > Sling Rewriter does not detect configuration changes coming in via move > ----------------------------------------------------------------------- > > Key: SLING-12245 > URL: https://issues.apache.org/jira/browse/SLING-12245 > Project: Sling > Issue Type: Improvement > Affects Versions: Rewriter 1.3.10 > Reporter: Konrad Windszus > Priority: Major > > If one renames/moves a JCR node from {{/apps/my/config/invalid-rewriter}} to > {{/apps/my/config/rewriter}} the new rewriter configuration is not being > detected by the {{ProcessorManagerImpl}} due to the > {{ResourceChangeListener}} only being configured to listen for changes below > the {{rewriter}} resource > (https://github.com/apache/sling-org-apache-sling-rewriter/blob/4d1952648e35e7001236f282040a78479f7726d4/src/main/java/org/apache/sling/rewriter/impl/ProcessorManagerImpl.java#L69). -- This message was sent by Atlassian Jira (v8.20.10#820010)
