[ 
https://issues.apache.org/jira/browse/SLING-12266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835759#comment-17835759
 ] 

Csaba Varga commented on SLING-12266:
-------------------------------------

I separated that change to a different commit because I wasn't sure about it, 
either. On one hand, it's the only way I can see to avoid running some code 
that parses a large CND file and tries to (redundantly) register the built-in 
node types. On the other hand, it _is_ a bit ugly, and it doesn't save that 
much time, according to my quick and dirty performance tests.

I can drop that part from my PR if that's the consensus.

> Cache initial repository state to improve JCR_OAK performance
> -------------------------------------------------------------
>
>                 Key: SLING-12266
>                 URL: https://issues.apache.org/jira/browse/SLING-12266
>             Project: Sling
>          Issue Type: Improvement
>          Components: Testing
>    Affects Versions: Testing Sling Mock 3.4.18
>            Reporter: Csaba Varga
>            Assignee: Stefan Seifert
>            Priority: Minor
>
> A lot of effort goes into preparing an Oak Mock repository from scratch: node 
> types need to be registered, indexes need to be created, and all this happens 
> over several commits. None of this work depends on the test case itself, so 
> it will always result in the exact same repository state. We could take the 
> root NodeState from the first repository we build, then build subsequent 
> repositories on top of it, avoiding most of the redundant work. Commits can 
> be relatively expensive even in memory, so each one we avoid can save a lot 
> of time in the long term.
>  
> This would require extending the contract between Testing Sling Mock and the 
> ResourceResolverTypeAdapters, to add optional "make snapshot" and "build repo 
> from snapshot" operations. For adapters that don't support them, we would 
> keep rebuilding things from scratch.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to