[ 
https://issues.apache.org/jira/browse/SLING-12287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836439#comment-17836439
 ] 

Stefan Seifert edited comment on SLING-12287 at 4/17/24 2:00 PM:
-----------------------------------------------------------------

looking deeper into this, i think it's not easy possible to have a single 
JAR/POM supporting both oak 1.22 and latest oak version at the same time. there 
is too much change between them, regarding supported jdks and the change guava 
is embedded.

i currently plan to do a branching of sling-mock-oak - one maintenance branch 
for 1.22.x and one for latest versions - this is in-line how oak itself it is 
doing. i started two draft PRs and will continue test the produced JARs in 
different project environments if this is working. maybe we can eliminate more 
of the shading/embedding in the latest sling-mock-oak version which would be a 
good thing.
 * sling-mock-oak 4.x with Oak 1.60: 
[https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/14]
 * sling-mock-oak 3.2.x with Oak 1.22: 
[https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/13]


was (Author: sseif...@pro-vision.de):
looking deeper into this, i think it's not easy possible to have a single 
JAR/POM supporting both oak 1.22 and latest oak version at the same time. there 
is too much change between them, regarding supported jdks and the change guava 
is embedded.

i currently plan to do a branching of sling-mock-oak - one maintenance branch 
for 1.22.x and one for latest versions - this is in-line how oak itself it is 
doing. i started two draft PRs and will continue test the produced JARs in 
different project environments if this is working. maybe we can eliminate more 
of the shading/embedding in the latest sling-mock-oak version which would be a 
good thing.
 * sling-mock-oak 4.x with Oak 1.60: 
https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/13
 * sling-mock-oak 3.2.x with Oak 1.22: 
https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/14

> sling-mock-oak: Update to Oak 1.60 and provide separate 1.22 release
> --------------------------------------------------------------------
>
>                 Key: SLING-12287
>                 URL: https://issues.apache.org/jira/browse/SLING-12287
>             Project: Sling
>          Issue Type: Improvement
>          Components: Testing
>            Reporter: Stefan Seifert
>            Assignee: Stefan Seifert
>            Priority: Major
>             Fix For: Testing Sling Mock Oak 3.2.0-1.22.15, Testing Sling Mock 
> Oak 4.0.0-1.60.0
>
>
> following the discussion with [~reschke] in SLING-12266 we should move away 
> from oak 1.44 which is quite outdated. however, we need to ensure to keep 
> compatibility with the old 1.22.x version range to support all sorts of 
> projects using the mocks.
> a solution might be to switch to a recent version of oak in the POM, and 
> create dedicated ITs to test against this and older 1.22.x versions to ensure 
> compatibility.
> the benefit is, that all projects that are "just using" sling-mock-oak 
> without thinking about the dependency management (e.g. not using something 
> like [https://wcm.io/tooling/maven/aem-dependencies.html)] will get the 
> latest version which is better supported.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to