[ 
https://issues.apache.org/jira/browse/SLING-12197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840821#comment-17840821
 ] 

Robert Munteanu commented on SLING-12197:
-----------------------------------------

Sure, if Niek has the time to look at it I'm all for it :-) I looked the 
initial PR from SLING-10931 and it's a lot of code, not easy to figure out 
where to insert what.

As for the test case, it would be very helpful if you could create a simple 
package with Sling initial content that install on the latest Sling Starter but 
fails when passed through the CP Converter. The bundle you linked above 
requires AEM-specific APIs and I can't use it for testing. 

> cpconverter: Sling-Initial-Content directories created as nt:folder instead 
> of sling:Folder
> -------------------------------------------------------------------------------------------
>
>                 Key: SLING-12197
>                 URL: https://issues.apache.org/jira/browse/SLING-12197
>             Project: Sling
>          Issue Type: Bug
>          Components: Content-Package to Feature Model Converter
>    Affects Versions: Content-Package to Feature Model Converter 1.3.4
>            Reporter: Stefan Seifert
>            Priority: Major
>             Fix For: Content-Package to Feature Model Converter 1.3.8
>
>         Attachments: io.wcm.handler.link-apps-1.10.2-cp2fm-converted.zip
>
>
> the cpconverter extracts Sling-Initial-Content from OSGi bundles and creates 
> FileVault packages with the transformed content.
> this works well, but there is one difference when the resulting content 
> package is installed compared when uploading the OSGi bundle with the 
> Sling-Initial-Content directly:
> * the JCR Content Loader by defaults creates a {{sling:Folder}} node type for 
> each directory found in the Sling-Initial-Content (see also 
> [docs|https://sling.apache.org/documentation/bundles/content-loading-jcr-contentloader.html#initial-content-loading-1])
> * the cpconverter process creates no {{.content.xml}} file for the folders, 
> but only for the actual JSON files found in the process. as a result, the 
> folders are created as {{nt:folder}} when uploading the transformed package
> * this difference becomes relevant, when a JSON file in Sling-Initial-Content 
> defines a primary type of {{nt:unstructured}} - it is not allowed to created 
> such a node directly below a {{nt:folder}} node - but it is allowed to do so 
> below a {{sling:Folder}} node



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to