rombert commented on PR #10:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-oak-server/pull/10#issuecomment-2107499868
@enapps-enorman - good catch with the `AuthInfoImpl`. I hand-rolled a
different implementation (which does not seem to work, not sure why). But we
still have the guava classess pulled in, e.g. via
`org.apache.jackrabbit.oak.plugins.commit.JcrConflictHandler`. I think it is
going to be very hard to make sure we don't transitively pull in Guava classes
from Oak, unfortunately. Perhaps @reschke can comment on that.
Regarding the actual fix, we can either
- go with this fix and keep making new releases for new Oak versions
- go with a wider bnd range ( and probably add extra tests ) ; we would
still need to keep making releases for new Oak versions but users of older
versions of Oak can upgrade to newer versions of the bundle
- inline the required guava classes in this bundle so we can get wide
compatibility; a good start for this is below
```
Private-Package: org.apache.jackrabbit.guava.common.base, \
org.apache.jackrabbit.guava.common.collect, \
org.apache.jackrabbit.guava.common.math, \
org.apache.jackrabbit.guava.common.base.internal, \
org.apache.jackrabbit.guava.common.primitives
```
I'll leave this with you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
