jsedding commented on code in PR #9:
URL:
https://github.com/apache/sling-org-apache-sling-installer-provider-jcr/pull/9#discussion_r1611777912
##########
src/main/java/org/apache/sling/installer/provider/jcr/impl/JcrInstaller.java:
##########
@@ -707,6 +716,7 @@ private UpdateResult handleUpdate(final String resourceType,
dataNode.setProperty(PROP_MODIFIED, Calendar.getInstance());
dataNode.setProperty(PROP_ENC, ENCODING);
dataNode.setProperty(PROP_MIME, MIME_TXT);
+ dataNode.setProperty(ORIGINAL_PID, id);
Review Comment:
I suggest we drop the original.pid. Instead we go with your approach of
checking for the legacy pid
(https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/pull/13/files#diff-ddf6029cf7d9aa5ed2720412a7fe8de77d7f5df784c32864c6abc54393e78321R95-R97).
That isn't quite as generic as I had originally intended, but it should be
good enough. Unless I am missing something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
