Thanks Stefan, I have just requested access to JIRA and will raise this as soon as it’s granted.
Thanks, Pete From: Stefan Seifert <stefan.seif...@diva-e.com.INVALID> Date: Tuesday, 17 September 2024 at 11:12 PM To: dev@sling.apache.org <dev@sling.apache.org> Subject: RE: Apache Sling Sitemap Extension Issue EXTERNAL: Use caution when clicking on links or opening attachments. hello peter. that definitely looks like a bug for me and should be changed to @ConsumerType. i'm not in the details of that project and are not sure if more of the related interfaces should be updated as well. can you create a JIRA ticket [1] to further track this issue? additionally, you could provide a PR if possible linked to that ticket. stefan [1] https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fissues.apache.org%2Fjira%2Fprojects%2FSLING%2F&data=05%7C02%7Ctos%40adobe.com%7C4acde9932a3e4365d9f408dcd71a5703%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C638621755338965040%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=cI8%2F5JE5ySbTHtOizlinAQjRmgbWkUW5Xon5lGGDL5w%3D&reserved=0<https://issues.apache.org/jira/projects/SLING/> > -----Original Message----- > From: Peter Tos <t...@adobe.com.INVALID> > Sent: Tuesday, September 17, 2024 3:08 AM > To: dev@sling.apache.org > Subject: Apache Sling Sitemap Extension Issue > > Hi Sling Community, > > I'm currently working on an AEM implementation where we are using the > Apache Sling Sitemap module. We are creating a custom sitemap to introduce > custom metadata for their Coveo search engine to index. > > I implemented a Custom Sling Sitemap Extension following the extension > pattern in the documentation, where we need to extend the marker > org.apache.sling.sitemap.builder.Extension interface with our custom > extension data, implement our custom extension interface and register the > Extension Instance, following the AlternateLangugaeExtension example. This > is working as expected and the sitemap is generating correctly. > > What I have noticed is that org.apache.sling.sitemap.builder.Extension is > annotated with @ProviderType and no classes outside of the bundle should > extend or implement a class annotated with @ProviderType. For our AEM > implementation, this is failing the code quality scan. > > With the Sitemap Extension approach requiring the consumer to extend the > Extension interface, is it possible to (or should we) remove @ProviderType > annotation from the interface? > > Thanks, > Pete
