[
https://issues.apache.org/jira/browse/SLING-12452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17890464#comment-17890464
]
Robert Munteanu commented on SLING-12452:
-----------------------------------------
[~olli] - yup, we can remove it. The downside is that we will lose fulltext
search.
{noformat}
[ERROR] Failures:
[ERROR] FullTextIndexingTest.testUploadedPdfIsIndexed:97 RetryLoop failed,
condition is false after 15 seconds: A document containing 'Excepteur' is found
under /tmp/test-FullTextIndexingTest
[ERROR] FullTextIndexingTest.testUploadedPdfIsIndexed:97 RetryLoop failed,
condition is false after 15 seconds: A document containing 'some text that we
will search for' is found under /var/test-FullTextIndexingTest
[ERROR] FullTextIndexingTest.testUploadedPdfIsIndexed:97 RetryLoop failed,
condition is false after 15 seconds: A document containing 'un autre PDF pour
le test fulltext' is found under /libs/test-FullTextIndexingTest
[INFO]
[ERROR] Tests run: 573, Failures: 3, Errors: 0, Skipped: 1
{noformat}
I think that full-text search is an important feature of Sling and we should
ensure that it works.
> Investigate removing embeding of Oak classes
> --------------------------------------------
>
> Key: SLING-12452
> URL: https://issues.apache.org/jira/browse/SLING-12452
> Project: Sling
> Issue Type: Improvement
> Components: Oak
> Reporter: Robert Munteanu
> Assignee: Robert Munteanu
> Priority: Major
> Fix For: JCR Oak Server 1.4.2
>
> Attachments: oak-server-bnd-report.txt
>
>
> The current version of the oak-server bundle currently embeds two oak classes
> {noformat}$ jar tf target/org.apache.sling.jcr.oak.server-1.4.1-SNAPSHOT.jar
> | grep -E 'jackrabbit.*class'
> org/apache/jackrabbit/oak/plugins/index/lucene/util/LuceneIndexHelper.class
> org/apache/jackrabbit/oak/plugins/index/search/util/IndexHelper.class
> {noformat}
> These classes seem to be responsible for pulling in the shaded Guava imports
> which make upgrading to new Oak version harder.
> Using {{bnd print --full
> target/org.apache.sling.jcr.oak.server-1.4.1-SNAPSHOT.jar}} I noticed the
> following usage report
> {noformat}[USEDBY]
> (...)
> org.apache.jackrabbit.guava.common.base
> org.apache.jackrabbit.oak.plugins.index.lucene.util
>
> org.apache.jackrabbit.oak.plugins.index.search.util
> org.apache.jackrabbit.guava.common.collect
> org.apache.jackrabbit.oak.plugins.index.search.util
> {noformat}
> If we could stop embedding the Oak classes the Guava imports should no longer
> be required.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
