[ 
https://issues.apache.org/jira/browse/SLING-12478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896697#comment-17896697
 ] 

Remo Liechti commented on SLING-12478:
--------------------------------------

Currently, messages like
{code:java}
"[52.55.183.88 [1730925644438] GET /rest/content/v4.api HTTP/1.1] 
org.apache.sling.engine.impl.SlingHttpServletResponseImpl Servlet 4392 tried to 
override the 'Content-Type' header from 'null' to 'null'. This is a violation 
of the RequestDispatcher.include() contract - 
https://jakarta.ee/specifications/servlet/4.0/apidocs/javax/servlet/requestdispatcher#include-javax.servlet.ServletRequest-javax.servlet.ServletResponse-."{code}
Do not give the developer any hint where the violation origins from.
The reasoning behind having all the RequestProgressTracker messages at the back 
of the log message is to give the developer who is going to fix the violation 
as much context as possible to figure out the origin of the violation.
The START_TIMER may be the ones that cause it, due to includes, but must not. 
Hence the decision to add all what we got.
Better approaches are very welcome.

> Add potential origins of violations to the RequestDispatcher include API
> ------------------------------------------------------------------------
>
>                 Key: SLING-12478
>                 URL: https://issues.apache.org/jira/browse/SLING-12478
>             Project: Sling
>          Issue Type: Improvement
>          Components: Engine
>            Reporter: Remo Liechti
>            Assignee: Remo Liechti
>            Priority: Minor
>             Fix For: Engine 2.15.18
>
>
> Add more information to the log about potential origins of the violation 
> message added in SLING-12454. 
> Use the RequestProgressTracker API to get the messages to find START_TIMER's 
> that do not have an END_TIMER yet, which means a violation is most likely 
> caused by that origin.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to