[ 
https://issues.apache.org/jira/browse/SLING-12599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17939431#comment-17939431
 ] 

Carsten Ziegeler commented on SLING-12599:
------------------------------------------

[~joerghoh] I extracted the HC into a separate class which gives us a cleaner 
code and makes the HC optional. The minor downside is that the PID and the 
property name for the HC changes - but as I don't expect this feature to be 
wildly used and as the next version is a major version change anyway, I don't 
see this as a huge problem.

see 
https://github.com/apache/sling-org-apache-sling-servlets-resolver/commit/6d6309b797fe1741cc1f7bd23cbdf6b5ab06d2e9

> Make dependency to Apache Felix HC optional
> -------------------------------------------
>
>                 Key: SLING-12599
>                 URL: https://issues.apache.org/jira/browse/SLING-12599
>             Project: Sling
>          Issue Type: Improvement
>          Components: Servlets
>    Affects Versions: Servlets Resolver 2.11.8
>            Reporter: Carsten Ziegeler
>            Assignee: Joerg Hoh
>            Priority: Major
>             Fix For: Servlets Resolver 3.0.0
>
>
> SLING-12417 introduced a mandatory dependency to Apache Felix HC API. However 
> in scenarios where HCs are not used, this now requires to install 
> dependencies which are not needed at runtime.
> We should make this optional
> The BundledScriptTracker is also unnecessarily registered as a (useless) 
> HealthCheck and then registers a real HC in activate - registering in 
> activate is an anti pattern which should be avoided



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to