[ https://issues.apache.org/jira/browse/SLING-2251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13164249#comment-13164249 ]
Alexander Klimetschek commented on SLING-2251: ---------------------------------------------- Probably not important, but the change in the test case made the isAbsolute case wrong: it does the same relative check as the else clause. - private static void assertEqualsUri(String expected, String actual) { - assertEquals(TEST_PREFIX + expected, actual); + private static void assertEqualsUri(String expected, String actual, boolean isAbsolute) { + if (isAbsolute) { + assertEquals(expected, actual); + } else { + assertEquals(expected, actual); + } } > RedirectServlet should create relative Location headers as often as possible > ---------------------------------------------------------------------------- > > Key: SLING-2251 > URL: https://issues.apache.org/jira/browse/SLING-2251 > Project: Sling > Issue Type: Improvement > Components: Servlets > Affects Versions: Servlets Get 2.1.2 > Reporter: Alexander Klimetschek > Attachments: SLING-2251.patch > > > SLING-1965 (more specifically > http://svn.apache.org/viewvc?view=revision&revision=903175 ) changed the > redirect servlet so that it _always_ generates an absolute location header. > The issue does not give much reasoning for that. > The problem is that this breaks cases where a Sling server is run behind a > proxy (which does not or cannot rewrite the Location header), as the redirect > ("http://localhost:8080/some/path") might not match the externally visible > domain (e.g. "https://my.domain.com"). Also, the schema is fixed (e.g. might > switch external https back to http). > A solution would be to generate absolute URLs only if a resource resolver > mapping (/etc/map) includes an explicit domain and thus generates an absolute > URL. For all other cases, relative URLs should be generated. AFAICS, this was > the case before SLING-1965. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira