[
https://issues.apache.org/jira/browse/SLING-12926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu resolved SLING-12926.
-------------------------------------
Resolution: Fixed
Thanks for the PR [~nscendoni], I applied it.
A follow-up question: it seems to me like the components are set up for
multiple IDPs, but now we have a singleton SlingLoginCookieManager.
If multiple IDPs are not a goal then it's all good, but otherwise we might to
take another pass at the API
> SlingLoginCookieManager hardcodes the idp name to 'oidc'
> --------------------------------------------------------
>
> Key: SLING-12926
> URL: https://issues.apache.org/jira/browse/SLING-12926
> Project: Sling
> Issue Type: Bug
> Components: Extensions
> Reporter: Robert Munteanu
> Assignee: Nicola Scendoni
> Priority: Major
> Fix For: OAuth Client 0.1.4
>
>
> While trying to configure the Sling OAuth Sample for OIDC login (
> https://github.com/apache/sling-samples/pull/18 ) [~nscendoni] figured out
> there is a problem in the SlingLoginCookieManager - the idp name is not as
> configured, but always 'oidc':
> https://github.com/apache/sling-org-apache-sling-auth-oauth-client/blob/2587f5dab5ee0dd168ddaa9a2072dace42e445f5/src/main/java/org/apache/sling/auth/oauth_client/impl/SlingLoginCookieManager.java#L143
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
