[ 
https://issues.apache.org/jira/browse/SLING-12954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18023111#comment-18023111
 ] 

Robert Munteanu commented on SLING-12954:
-----------------------------------------

I think the points mentioned in the issue description are good when taken 
individually but interact in unfortunate ways.

A quick search in thee Sling repo checkout shows that only the starter uses 
these patterns. I think it would be useful to archive artifacts from 
non-reference stages.

{noformat}
$ find -name .sling-module.json | xargs grep -A 3 'archivePatterns'
./org-apache-sling-starter/.sling-module.json:        "archivePatterns": [
./org-apache-sling-starter/.sling-module.json-            "**/logs/*.log"
./org-apache-sling-starter/.sling-module.json-        ]
./org-apache-sling-starter/.sling-module.json-    }
{noformat}

> Starter IT failures can miss archiving artifacts in case of build failures
> --------------------------------------------------------------------------
>
>                 Key: SLING-12954
>                 URL: https://issues.apache.org/jira/browse/SLING-12954
>             Project: Sling
>          Issue Type: Bug
>          Components: Build and Source Control, Starter
>            Reporter: Robert Munteanu
>            Priority: Major
>
> I was looking at 
> [https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-starter/job/PR-533/1/cloudbees-pipeline-explorer/]
>  and I don't see any artifacts archived.
> The Starter does configure archival for logs - 
> https://github.com/apache/sling-org-apache-sling-starter/blob/0fe874aa1a10d5813471c34c903c02d61cf141df/.sling-module.json#L15-L17
>  but this is done only for 'reference' stages - 
> https://github.com/apache/sling-tooling-jenkins/blob/a9c7d5f999acb07c050e1ac0d824196ab3fcc1fc/vars/slingOsgiBundleBuild.groovy#L214-L216
>  .
> Since
> - a failure in any stage causes the others to abort
> - we run against 3 JDKs in the Starter
> - the reference JDK is the older one
> - only artifacts for the 'reference' build are archived
> The changes for the artifacts to be archived is actually very small.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to