enapps-enorman commented on PR #69: URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/69#issuecomment-3735919373
> Thank you for the suggestion! I’m a bit hesitant to use the annotation since it adds redundancy (it’s the default) and might slightly complicate the future JUnit 5 migration. Would adding an explicit assertion be an acceptable alternative to satisfy Sonar? Sure, both ways satisfy sonar. I just suggested it as maybe a slightly more readable code. The runtime behavior after declaring None expected is the same as the default, but doing it that way is another way to inform sonar that you thought about it and intentionally didn't have assertions in the test. The JUnit 5 equivalent would be the Assertions.assertDoesNotThrow around your code block. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
