joerghoh commented on code in PR #52:
URL:
https://github.com/apache/sling-org-apache-sling-event/pull/52#discussion_r2698703857
##########
src/main/java/org/apache/sling/event/impl/jobs/config/JobManagerConfiguration.java:
##########
@@ -248,9 +248,7 @@ protected void unbindJobProcessingEnabledCondition(final
Condition condition) {
if (this.jobProcessingEnabledCondition == condition) {
this.jobProcessingEnabledCondition = null;
logger.info("Job processing readiness condition has been removed -
jobs will not be processed");
- // Signal jobs to stop before notifying listeners
stopProcessing();
- notifyListeners();
Review Comment:
``this.topologyCapabilities`` is only set during start and stop of the
JobManager, in other words: If this value is ``null`` the job engine is not
started, and it does not make sense to notify listeners (this condition is
implicitly, as ``notifyListeners`` is invoked only via ``startProcessing`` and
``stopProcessing``.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
