bkkothari2255 commented on code in PR #85:
URL:
https://github.com/apache/sling-org-apache-sling-models-impl/pull/85#discussion_r2981436958
##########
src/main/java/org/apache/sling/models/impl/ModelPackageBundleListener.java:
##########
@@ -200,6 +200,13 @@ private void analyzeClass(Bundle bundle, String className,
List<ServiceRegistrat
bundle.getSymbolicName(),
e.getLocalizedMessage(),
e);
+ } catch (LinkageError e) {
+ log.error(
Review Comment:
Minor but in production environments, teams typically have alerting on
`ERROR` logs — this will fire alerts every time a bundle with a missing
optional dep is deployed. The `ClassNotFoundException` catch right above uses
`warn` for the same kind of recoverable situation, so this should match.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
