cziegeler commented on code in PR #75:
URL:
https://github.com/apache/sling-org-apache-sling-engine/pull/75#discussion_r3285915497
##########
src/main/java/org/apache/sling/engine/impl/SlingMainServlet.java:
##########
@@ -90,6 +91,10 @@ public class SlingMainServlet extends GenericServlet {
@Reference
private volatile SlingRequestProcessorImpl requestProcessorImpl;
+ /** extra config properties for multipart file upload support */
+ @Reference
+ private transient RequestParameterConfig reqParamConfig;
Review Comment:
I have seen dozens of such changes in general which actually made the code
worse just to get rid off warnings in some tool. Lets agree that transient in
this case is not needed, but it doesnt hurt either. So lets just move on..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
