royteeuwen opened a new pull request, #34:
URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/34

   LogStoreRegistrar hard-coded the LogStoreAppender's "loggers" service 
property to "ROOT", so the in-memory store only captured events that propagate 
to ROOT. Loggers configured with additivity=false (log.request, log.access, 
audit logs, etc.) never reached it.
   
   Add an optional "loggers" property on the existing 
org.apache.sling.commons.log.LogStore PID (default ["ROOT"], preserving today's 
behaviour). LogStoreRegistrar parses it via the OSGi Converter and uses it as 
the appender service property, so AppenderTracker attaches the store to each 
named logger. Reconfiguration is hot: changing the property invokes 
setProperties on the existing registration and AppenderTracker.modifiedService 
re-attaches.
   
   Example org.apache.sling.commons.log.LogStore.cfg.json:
   
     {
         "maxEntries:Integer": 10000,
         "loggers": ["ROOT", "log.request", "log.access"]
     }
   
   Additive change: configurations that don't set "loggers" get the historical 
["ROOT"] default. No public API change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to