royteeuwen commented on PR #33: URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/33#issuecomment-4567541116
> Thanks for the PR @royteeuwen ! I would have two high-level comments. > > 1. I think LogStoreListener should not reference `LogStore` . The fact that we use the LogStore to propagate log entries is an implementation detail that might change. So it needs a new name . > 2. There are two changes in this PR: > > 1. LogEntry changes (new fields) and LogStore config changes ( loggers property ) > 2. Main functionality to propagate log entries to registered listeners > > These should be split up in separate issues. I split off the log store config changes to another PR: https://github.com/apache/sling-org-apache-sling-commons-log/pull/34 I kept the LogEntry changes, because the goal of this PR / ticket is to be able to easily produce telemetry data, which means we need more structured data in the LogEntry class. I did make it a separate commit though -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
