daniancu commented on PR #20:
URL:
https://github.com/apache/sling-org-apache-sling-discovery-oak/pull/20#issuecomment-5175845374
> There seems to be a larger refactoring included which splits up the code
of {{doUpdateProperties()}} into multiple methods. Is this required in the
context of this PR? If not, it should be a PR on its own.
After the small change this PR added to `doUpdateProperties`, Sonar flagged
the method as `Brain method` and I fixed it here (last 3/5 commits). Now I
think I could have done the refactoring in a separated PR, merge that one than
rebase this one on it. Let me do that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
