rombert commented on code in PR #62:
URL:
https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/62#discussion_r3749734392
##########
src/test/java/org/apache/sling/feature/analyser/task/impl/repoinitconflicts/RepoInitConflictsValidatorTest.java:
##########
@@ -69,9 +69,10 @@ void shouldReportConflictForSamePathDifferentType() {
assertTrue(report.hasConflicts());
List<String> result = report.generate();
- assertTrue(result.get(1).contains("Incorrect repoinit for feature"));
- assertTrue(result.get(2).contains("Found 1 sets of conflicting
repoinit statements"));
- assertTrue(result.get(3).contains("/apps/a/b"));
+ assertTrue(result.get(1).contains("Repoinit validation conflict
summary"));
Review Comment:
I think the changes are going in the right direction, good proposal.
I would propose the actual structure:
```
Repoinit validation conflict summary for feature xxx: found 1 conflict(s)
Conflicting repoinit statement set 1/1:\n
create path /foo/bar\n
create path /foo/[sling:Folder]bar
```
I think the summary line is a bit more readable as it clearly shows the
summary ( after the `:` separator) and that adding a counter to the conflicting
statement set makes it easier to track.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
