rombert commented on code in PR #57:
URL:
https://github.com/apache/sling-org-apache-sling-testing-clients/pull/57#discussion_r3948713298
##########
pom.xml:
##########
@@ -192,12 +192,12 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
- <version>3.2.5</version>
+ <version>3.6.0</version>
Review Comment:
Do you need this specific version? If not I suggest you remove both surefire
and failsafe plugin declarations because we already managed them in the parent
pom. They are slightly older but if you don't need them we should not add them
to the pom. The following change works for me on top of your PR
```patch
diff --git a/pom.xml b/pom.xml
index a00bdad..e6a08a1 100644
--- a/pom.xml
+++ b/pom.xml
@@ -189,16 +189,6 @@
<groupId>biz.aQute.bnd</groupId>
<artifactId>bnd-baseline-maven-plugin</artifactId>
</plugin>
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-surefire-plugin</artifactId>
- <version>3.6.0</version>
- </plugin>
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-failsafe-plugin</artifactId>
- <version>3.6.0</version>
- </plugin>
<plugin>
<groupId>org.apache.rat</groupId>
<artifactId>apache-rat-plugin</artifactId>
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
