rishabhdaim commented on PR #29: URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/29#issuecomment-5871677679
> hi @rishabhdaim , thanks for the heads up. i had another quick look and my comments is addressed. thank you. > > one thing that came to my mind: i vaguely remember that we attempted to fix that before. i might be mistaken and it was a different but similar sounding issue. anyway, my point is: maybe have a quick check to see if there is with this fix some dead code in the sling auth part that needs a cleanup aka some love. @anchela thanks for the quick review. I looked through the history and found an older `stackGuard` fix in `AuthenticationInfo`, but that handles a different recursion issue in the read-only map wrapper. The other existing checks are also for separate login flows, so I don’t see anything from this PR that’s redundant or should be removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
