joerghoh commented on code in PR #26:
URL:
https://github.com/apache/sling-org-apache-sling-i18n/pull/26#discussion_r4314855875
##########
src/main/java/org/apache/sling/i18n/impl/JcrResourceBundleProvider.java:
##########
@@ -281,23 +289,45 @@ private void onChange(final ChangeStatus status, final
ResourceChange change) th
if (status.resourceResolver == null) {
status.resourceResolver = createResourceResolver();
}
- if (isDictionaryResource(status.resourceResolver, change)) {
+ if (requiresDictionaryRediscovery(status.resourceResolver, change,
withinKnownDictionary)) {
status.reloadAll = true;
}
Review Comment:
``status`` is passed into ``onChange()`` (across all changes being
processed) and thus it could revert ``status.reloadAll`` back to ``false`` even
if a prior execution had it set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
