rishabhdaim opened a new pull request, #73:
URL: https://github.com/apache/sling-parent/pull/73
## Summary
Add a shared SLF4J 1.7 compatibility version for modules that still support
older runtime distributions, without changing the SLF4J 2.x default.
## Changes
Define `slf4j.compat.version` as `1.7.36` and document the opt-in next to
the property. After upgrading to the parent release containing this change,
modules can add or replace one entry in their existing `<properties>`:
```xml
<slf4j.version>${slf4j.compat.version}</slf4j.version>
```
Both `slf4j-api` and `slf4j-simple` already use `slf4j.version`, so the API
and test binding stay aligned. No profiles, command-line flags, or
dependency-management overrides are needed. Removing the override restores the
default.
Module migrations and runtime logging-provider changes are outside this PR.
## Test Plan
- [x] Run `mvn -pl sling-parent,sling-bundle-parent spotless:apply`.
- [x] Run `mvn test verify -Dspotless.action=check` on Java 17.
- [x] Check consumer effective POMs inheriting from each parent: both
managed SLF4J artifacts remain at `2.0.17` by default and switch to `1.7.36`
when opted in.
- [x] Resolve dependencies from consumer POMs with the plain property
override, without profiles or flags: API `1.7.36` with `provided` scope and
simple binding `1.7.36` with `test` scope, for both parent types.
- [x] Self-review against the existing CAConfig module override pattern;
include a copyable opt-in in the POM comment.
## Links
- JIRA: https://issues.apache.org/jira/browse/SLING-13430
- Related compatibility issues: SLING-13428, SLING-13342
Co-Authored-By: GitHub Copilot <[email protected]>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]