stefanseifert commented on PR #20: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/20#issuecomment-6855302767
i appreciate the simplifaction for the users so the plugin construct is not needed. however, i'm not sure, does it come with extra cost performance-wise? take into account that 99% of projects and unit tests will not make use of this feature at all. but some stuff is still registered in that normal use case - i did not dive into the full code to check if it really is a problem. if this new feature is not required by a project, it should have zero-cost effect on the unit test run time. maybe it can be easily changed that the stuff only gets registered when a valid oak-lucene dependency is found in the classpath, this should be a cheap check? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
