cziegeler commented on code in PR #75:
URL:
https://github.com/apache/sling-org-apache-sling-engine/pull/75#discussion_r4611208782
##########
src/main/java/org/apache/sling/engine/impl/parameters/MultipartRequestParameter.java:
##########
@@ -117,15 +123,16 @@ public String getString() {
return this.cachedValue;
}
- return this.delegatee.getString();
+ return new String(this.get());
Review Comment:
Addressed in f78287e. Uploaded-file getString() now honors the charset from
the part Content-Type (including quoted and case-insensitive charset
parameters), with ISO-8859-1 as the default, matching the previous DiskFileItem
behavior. The request encoding no longer overrides file-content decoding; form
fields and explicit getString(encoding) calls retain their behavior. Added
regression coverage for non-ASCII content, defaults, unsupported charsets, and
explicit overrides.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]