[ https://issues.apache.org/jira/browse/SLING-2411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206405#comment-13206405 ]
Julian Sedding commented on SLING-2411: --------------------------------------- Please don't let the many lines of new code distract you. They are mainly generic implementations of ResourceResolverWrapper and IteratorWrapper. The "real" changes are the addition of RequestScopedResourceResolverWrapper and changes in SlingMainServlet and ResourceDecoratorTracker. > ResourceDecorator(Resource, HttpServletRequest) doesn't get called > consistently > ------------------------------------------------------------------------------- > > Key: SLING-2411 > URL: https://issues.apache.org/jira/browse/SLING-2411 > Project: Sling > Issue Type: Improvement > Reporter: Justin Edelson > Attachments: SLING-2411-jsedding.patch > > > The ResourceDecorator currently has two methods: > decorate(Resource) > decorate(Resource, HttpServletRequest) > The JcrResourceResolver uses the latter method when > resolve(HttpServletRequest,String) is invoked. In all other cases, the former > method is used. This behavior is correct. > However, the JcrResourceResolver (and any future ResourceResolver > implementation for that matter) really doesn't have any control over how it > is invoked. For example, at present <sling:include> and <sling:forward> call > resolve(String), not resolve(HttpServletRequest,String) (see > http://s.apache.org/lL5). But even if we did a code audit within Sling and > fixed all the cases like this, we don't have any control over downstream > applications which may or may not invoke the two-argument resolve() method. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira