[ 
https://issues.apache.org/jira/browse/SLING-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13421396#comment-13421396
 ] 

Endolf commented on SLING-2536:
-------------------------------

getLocale() always returns the locale that was asked for, even when it's fallen 
back to something else. I can't paste the code in here, but here is what I've 
done.

I've extended the SetBundleTag from the standard el tag library, in the 
doEndTag I get the locale from the request from pageContext, then I get the 
request, cast to a SlingHttpServletRequest and call the getResourceBundle 
method passing in the bundle basename and the locale I just got from the 
request.

I think store that in javax.servlet.jsp.jstl.fmt.localizationContext in page 
context so that the standard fmt tags can use the bundle.

We then just use the standard tags to access the bundle as we would in any 
other j2ee app.


                
> JcrResourceBundle breaks the contract of getLocale
> --------------------------------------------------
>
>                 Key: SLING-2536
>                 URL: https://issues.apache.org/jira/browse/SLING-2536
>             Project: Sling
>          Issue Type: Bug
>    Affects Versions: i18n 2.2.2
>            Reporter: Endolf
>
> The javadoc for getLocale state that it should return the locale of this 
> bundle or the locale of the fallback. Currently JcrResourceBundle always 
> returns the requested locale even if there is no mix:language for that locale.
> e.g. Only a mix:language with a jcr:language en is in the jcr, a request for 
> a resource bundle of sv will return a ResourceBundle object where getLocale 
> returns sv. This should return en according to the javadoc.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to