2012/8/13 Bertrand Delacretaz <bdelacre...@apache.org>: > On Mon, Aug 13, 2012 at 2:14 PM, Carsten Ziegeler <cziege...@apache.org> > wrote: >> 2012/8/13 Bertrand Delacretaz <bdelacre...@apache.org>: > >>> ...The first SLING-1412 commit is svn revision 916419, and the >>> SlingDefaultValuesTest#testDefaultBehaviour test hasn't changed since >>> rev 656302, so I think the "remove property on empty value" behavior >>> has been there from rev 656302 or even earlier. >> >> Yes, I have the same feeling, but then why has SLING-1412 filed? :) > > IIUC the use case for that is a request with the following parameters > > /stringProperty@TypeHint=String[] > ./stringProperty@IgnoreBlanks=true > ./stringProperty=foo > ./stringProperty=bar > ./stringProperty= > > which should set only two values in the stringProperty multi-value > field, instead of three without @IgnoreBlanks. > > If I'm right we could probably restrict IgnoreBlanks to multi-value > properties, if that helps clarifying things. > >> ...the current code only implements some strange behaviour for >> @IgnoreBlanks which in one way or the other has to be fixed.... > > Ok, but IMO the "remove property if no value is provided for it" > behavior needs to stay. > Yes, interestingly a lot of the integration tests fail otherwise - which really surprises me. But that's a different story.
I think we should deprecate @IgnoreBlanks, properly document how blank values are really handled, and then implement SLING-2534 which is the opposite of @IgnoreBlanks Carsten -- Carsten Ziegeler cziege...@apache.org
