[
https://issues.apache.org/jira/browse/SLING-2746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13585813#comment-13585813
]
Carsten Ziegeler commented on SLING-2746:
-----------------------------------------
I think this should be split up into two issues, as the larger part of the
patch is for commons testing.
For the threading change: a thread should not hold a lock when calling into the
framework - in this case, I think there is no syncing required, as these static
methods are called from the BundleActivator which has a defined order. Maybe we
shoudln't use a static field to store the information and make this an object
field to be sure to avoid any potential problems.
> Commons threading contains a few minor multithreaded correctness bugs.
> (FindBugs)
> ---------------------------------------------------------------------------------
>
> Key: SLING-2746
> URL: https://issues.apache.org/jira/browse/SLING-2746
> Project: Sling
> Issue Type: Bug
> Components: Commons
> Affects Versions: Commons Threads 3.1.0
> Reporter: Ian Boston
> Assignee: Ian Boston
> Fix For: Commons Threads 3.2.0
>
> Attachments: SLING-2746.patch
>
>
> Some invalid double null checks and static value initialisations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira