Thank you Bertrand for the more precise javadocs. I have also changed to javadoc from AccessSecurityException to be more generic. (commited in r1464476)
best regards Mike > -----Original Message----- > From: Bertrand Delacretaz [mailto:[email protected]] > Sent: Thursday, April 04, 2013 10:05 AM > To: [email protected] > Subject: Re: Feedback on the current ResourceAccessSecurity API > > Hi Mike, > > On Wed, Apr 3, 2013 at 9:18 PM, Mike Müller <[email protected]> wrote: > > ...I commited a last shot of the SPI API. The Sling API hasn't changed > > anymore. I think the API is now complete and after all the discussions > > enough mature.... > > I have added/tweaked javadocs on the ResourceAccessSecurity interface > in revision 1464342, could you cross-check? > > Also, the AccessSecurityException javadoc says "Exception thrown by > ResourceAccessGate#sanitizeQuery(String, String, > org.apache.sling.auth.core.spi.AuthenticationInfo) if the query is not > allowed or illegal.", I would move that info to the sanitizeQuery > method instead, and make the exception description more generic - feel > free to do that if you agree. > > -Bertrand
