[ 
https://issues.apache.org/jira/browse/SLING-2853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13648363#comment-13648363
 ] 

Bertrand Delacretaz commented on SLING-2853:
--------------------------------------------

I agree with Felix on the package names, IMO this is clearly an extensions 
module, not for the core Sling API bundle.

Can't you use the adapter pattern Instead of 
ResourceCollectionManager.getByPath(...) ? Adapt a Resource to a 
ResourceCollectionManager.

IMO ResourceCollectionManager.deleteCollection can also go away - adapt the 
ResourceCollectionManager to a Resource (or add a getResource() method to it) 
and delete that.

You can then rename ResourceCollectionManager to ResourceCollectionFactory, as 
the remaining two methods are about creating a ResourceCollection.

Automated tests wouldn't hurt, of course.
                
> Add ResourceCollection to SLING
> -------------------------------
>
>                 Key: SLING-2853
>                 URL: https://issues.apache.org/jira/browse/SLING-2853
>             Project: Sling
>          Issue Type: New Feature
>          Components: API
>    Affects Versions: API 2.0.2
>            Reporter: Amit Gupta
>            Priority: Minor
>         Attachments: resourcecollection.zip
>
>
> Creating a collection of resources has been a use case for a while and there 
> has been no inherent support in SLING for the same.
> This proposal is to add a ResourceCollection interface and implementation 
> that allows creation of collection of resources. 
> Collection is a simple list of members, where each member contains path of 
> resource it refers to. In future, we might need to store additional 
> information with the member, hence following structure is proposed
> N: resourceCollection (nt:unstructured)
>         + P: sling:resourceType
>         + N : members (nt:unstructured)
>             + N: member_res1  > nt:unstructured
>                 + P: path > string, reference to actual resource
>             + N: member_res2  > nt:unstructured
>                 + P: path > string, reference to actual resource

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to