Bertrand- This all looks good to me. I would like to see condition metadata provided in the @Adapter annotation. But this can be added after you commit (just ideally before the release).
Regards, Justin On Tue, Jul 2, 2013 at 10:09 AM, Bertrand Delacretaz <bdelacre...@apache.org > wrote: > Hi, > > As this touches the sling.api bundle, I have attached a patch [1] for > review ,see SLING-2938 for more details. All the TODOs in that issue > have been implemented. > > I plan to commit this later this week, unless someone objects. > > -Bertrand > > [1] > https://issues.apache.org/jira/secure/attachment/12590435/SLING-2938-api.patch >
