Hi Some comments
* The new AdapterProvider interface needs a @since tag (I generally list the API export version and bundle version) * Technically exporting the o.a.s.api.adapter package at 2.2.1 is wrong and may lead to erroneous Import-Package statements for implementors: [2.2,3) instead of [2.2.1,3). I have quickly scanned our Sling-based application: The only bundle having the narrow [2.2,2.3) import version range is the Adpater Manager bundle (which is to be adapted anyways). All other bundles either import [2.x,3) or even "2.x". So I would suggest to export at 2.3. Regards Felix Am 02.07.2013 um 16:09 schrieb Bertrand Delacretaz: > Hi, > > As this touches the sling.api bundle, I have attached a patch [1] for > review ,see SLING-2938 for more details. All the TODOs in that issue > have been implemented. > > I plan to commit this later this week, unless someone objects. > > -Bertrand > > [1] > https://issues.apache.org/jira/secure/attachment/12590435/SLING-2938-api.patch
