[ 
https://issues.apache.org/jira/browse/SLING-2024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13749916#comment-13749916
 ] 

Felix Meschberger commented on SLING-2024:
------------------------------------------

Thanks for the code, very much appreciated. I will integrate it into the 
existing Commons Log module thereby replacing the old SLF4J implementation.

Some questions, though, while scanning the source:
 * What is the source and license for prettify.js ?
 * src/main/resources has a rebel.xml file: Can we remove this ?
 * OsgiAction extends a private class: Is that really required ?

As for JUL Bridging: I just copied the integration from the current Activator.
                
> Replace file logger with logback
> --------------------------------
>
>                 Key: SLING-2024
>                 URL: https://issues.apache.org/jira/browse/SLING-2024
>             Project: Sling
>          Issue Type: Improvement
>          Components: Commons
>    Affects Versions: Commons Log 2.1.2
>            Reporter: Carl Hall
>            Assignee: Felix Meschberger
>             Fix For: Commons Log 4.0.0
>
>         Attachments: 
> org.apache.sling.extensions.logback-0.0.1-SNAPSHOT-src.tar.gz
>
>
> Rather than doing the work internally of writing log messages to disk, the 
> internal log mechanism should use logback to handle the heavy lifting. This 
> also adds the ability to add appenders and other nifty logback features.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to