[
https://issues.apache.org/jira/browse/SLING-2024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13749933#comment-13749933
]
Chetan Mehrotra edited comment on SLING-2024 at 8/26/13 9:19 AM:
-----------------------------------------------------------------
Thanks Felix for looking into this
{quote}
What is the source and license for prettify.js ?
{quote}
It is taken from http://code.google.com/p/google-code-prettify/ and is under
ASL 2.0. I have added NOTICE, DEPENDENCIES and LICENSE file also
{quote}
src/main/resources has a rebel.xml file: Can we remove this ?
{quote}
Yes. Removed it in new attachment
{quote}
OsgiAction extends a private class: Is that really required
{quote}
This class needs to be referred to in Logback config file [1]. So I created a
shadow file for this in public namespace as referring to class name with
'internal' name in package does not look good
{quote}
As for JUL Bridging: I just copied the integration from the current Activator.
{quote}
I have added support for that in updated build along with a testcase. Minor
change from earlier build was to move Manager initialization *after* bridge
handler is installed.
I have added some more testcase and features in new build. So you can take that
as base
[1] https://github.com/chetanmeh/sling-logback#external-config-file
was (Author: chetanm):
Thanks Felix for looking into this
> What is the source and license for prettify.js ?
It is taken from http://code.google.com/p/google-code-prettify/ and is under
ASL 2.0. I have added NOTICE, DEPENDENCIES and LICENSE file also
> src/main/resources has a rebel.xml file: Can we remove this ?
Yes. Removed it in new attachment
> OsgiAction extends a private class: Is that really required
This class needs to be referred to in Logback config file [1]. So I created a
shadow file for this in public namespace as referring to class name with
'internal' name in package does not look good
> As for JUL Bridging: I just copied the integration from the current Activator.
I have added support for that in updated build along with a testcase. Minor
change from earlier build was to move Manager initialization *after* bridge
handler is installed.
I have added some more testcase and features in new build. So you can take that
as base
[1] https://github.com/chetanmeh/sling-logback#external-config-file
> Replace file logger with logback
> --------------------------------
>
> Key: SLING-2024
> URL: https://issues.apache.org/jira/browse/SLING-2024
> Project: Sling
> Issue Type: Improvement
> Components: Commons
> Affects Versions: Commons Log 2.1.2
> Reporter: Carl Hall
> Assignee: Felix Meschberger
> Fix For: Commons Log 4.0.0
>
> Attachments:
> org.apache.sling.extensions.logback-0.0.1-SNAPSHOT-src.tar.gz,
> org.apache.sling.extensions.logback-0.0.1-SNAPSHOT-src.tar.gz
>
>
> Rather than doing the work internally of writing log messages to disk, the
> internal log mechanism should use logback to handle the heavy lifting. This
> also adds the ability to add appenders and other nifty logback features.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
