[ 
https://issues.apache.org/jira/browse/SLING-3049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13795041#comment-13795041
 ] 

Chetan Mehrotra commented on SLING-3049:
----------------------------------------

bq. Wouldn't it better to set this module to java 6 instead of introducing 
specific animal sniffer settings? I'm in favor of Java 6.

Problem is not due to usage of JDK 6 API but usage of 
{{sun.reflect.Reflection}} class and I am not able to exclude it from animal 
sniffer check.

bq. Also, is there a simple way to add automated tests? Maybe just verify that 
the patch does something, no need to go into detail probably.

Not sure if it can be tested in a simple way.I can add an integration testcase 
and have an appender which can check the packaging data from LoggingEvent 
created for an exception. That would take some time

> Make Logback Stacktrace Packaging data support OSGi aware
> ---------------------------------------------------------
>
>                 Key: SLING-3049
>                 URL: https://issues.apache.org/jira/browse/SLING-3049
>             Project: Sling
>          Issue Type: Improvement
>          Components: Commons
>            Reporter: Chetan Mehrotra
>              Labels: logback
>         Attachments: SLING-3049.patch
>
>
> Logback provides a useful feature where it dumps the Class packaging Data 
> along with the stacktrace [1]. This provides a quick view of the location 
> from where classes in a given stacktrace are coming. Its default logic does 
> not work properly in OSGi env. Hence it would be useful to patch its logic to 
> become OSGi aware
> [1] http://logback.qos.ch/reasonsToSwitch.html#packagingData



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to