[ 
https://issues.apache.org/jira/browse/SLING-3223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13814738#comment-13814738
 ] 

Bertrand Delacretaz commented on SLING-3223:
--------------------------------------------

I haven't looked at your code yet but the following:

{code}
HTTP GET http://host:port/system/replication/agent/configuration/foo for 
retrieving configuration of agent foo
HTTP POST (/w parameters) to 
http://host:port/system/replication/agent/configuration/foo for updating 
configuration of agent foo
{code}

Makes me think you're using your own configuration mechanism instead of using 
OSGi configs, as Toby also notes. Is there a reason for that? Otherwise, using 
OSGi configs should allow you to get rid of some code, and reuse the standard 
webconsole and other tools to manage configs.

But all this can be handled once your code is donated, IMO it doesn't prevent 
us from committing your code once the paperwork is ok.

> Donation of a replication module for Sling
> ------------------------------------------
>
>                 Key: SLING-3223
>                 URL: https://issues.apache.org/jira/browse/SLING-3223
>             Project: Sling
>          Issue Type: Task
>          Components: Extensions
>            Reporter: Tommaso Teofili
>         Attachments: SLING-3223.patch
>
>
> Issue to track donation of a replication module for Sling, see thread at 
> http://markmail.org/thread/ic62k5pc34ppb5ko 



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to