Hi,

On Fri, Nov 15, 2013 at 8:40 AM, Felix Meschberger <fmesc...@adobe.com> wrote:
> So, finally, I agree that baking the feature flag support directly into the 
> ResourceResolver
> implementation is suboptimal, it is probably still the most comprehensive and 
> complete
> solution to the requirements...

I had another look at this, and the existing ResourceDecorator already
plays a similar role as an extension point to "do something" to each
Resource while it's being resolved. That's already baked in the
resource resolver, so we can leverage it without requiring much code
changes.

ResourceDecorator.decorate(Resource r) returning null is currently
only vaguely specified and certainly not used, as that causes NPEs in
places - I think we just need to clarify that decorate returning null
causes a Resource to be ignored, fix the code so that it's true and
we're good.

I have created SLING-3267 to track that, I'll create a patch for review there.

-Bertrand

Reply via email to