[ https://issues.apache.org/jira/browse/SLING-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13846290#comment-13846290 ]
Antonio Sanso commented on SLING-2762: -------------------------------------- bq. Will you also take care of the patch provided by Tim for SLING-3179 ? yes I can try :) > AbstractSlingRepository#login violates JCR spec > ----------------------------------------------- > > Key: SLING-2762 > URL: https://issues.apache.org/jira/browse/SLING-2762 > Project: Sling > Issue Type: Bug > Components: JCR > Reporter: Antonio Sanso > > AbstractSlingRepository#login seems to violate the javax.jcr.Repository spec. > The API [0] says > " If credentials is null, it is assumed that authentication is handled by a > mechanism external to the repository itself (for example, through the JAAS > framework) and that the repository implementation exists within a context > (for example, an application server) that allows it to handle authorization > of the request for access to the specified workspace." > while the implementation looks like > {code} > ... > if (credentials == null) { > credentials = getAnonCredentials(this.anonUser); > } > ... > {code} > [0] > http://www.day.com/maven/jsr170/javadocs/jcr-2.0/javax/jcr/Repository.html#login%28javax.jcr.Credentials,%20java.lang.String%29 -- This message was sent by Atlassian JIRA (v6.1.4#6159)