[ 
https://issues.apache.org/jira/browse/SLING-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13860098#comment-13860098
 ] 

Przemo Pakulski commented on SLING-3249:
----------------------------------------

Proposed fix is very simple, which is good :). I wondered for a moment where to 
put this cache checking condition.
It's a bit tricky because of key escaping. Does the fix work with properties 
using prefixes e.g. jcr:created ?

If so then it's ok, I think.

> Cache not properly used in JcrPropertyMap
> -----------------------------------------
>
>                 Key: SLING-3249
>                 URL: https://issues.apache.org/jira/browse/SLING-3249
>             Project: Sling
>          Issue Type: Bug
>          Components: JCR
>    Affects Versions: JCR Resource 2.2.8
>            Reporter: Przemo Pakulski
>            Assignee: Carsten Ziegeler
>              Labels: perfomance
>             Fix For: JCR Resource 2.3.0
>
>
> JcrPropertyMap class has internal cache for properties an values.
> The cache is not used correctly, e.g. reading the same property twice still 
> results in access to underlying node.
> The problem is with get() methods, when property is red it is put into the 
> cache, but the cache is never checked if it already contains the property.
> The only way to force the caching is to use readFully() method indirectly, in 
> this case read method is examining the cache.
> It looks this has been introduced by fixing SLING-2425.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to