+1
On Tue, Jul 1, 2014 at 5:55 AM, Stefan Egli <stefane...@apache.org> wrote: > +1 > (verified md5 & sha1 using the check_staged_release.sh) > > Cheers, > Stefan > > On 7/1/14 8:34 AM, "Carsten Ziegeler" <cziege...@apache.org> wrote: > > >Thanks for redoing, Robert. > > > >+1 > > > >Carsten > > > > > >2014-07-01 2:01 GMT+02:00 Justin Edelson <jus...@justinedelson.com>: > > > >> +1 > >> > >> On Mon, Jun 30, 2014 at 12:14 PM, Robert Munteanu <rob...@lmn.ro> > wrote: > >> > I think I've gotten the right Maven/Tycho incantations set up and > >> > deployed the 1.0.0 artifacts to > >> > > >> > > >> https://repository.apache.org/content/repositories/orgapachesling-1072/ > >> > > >> > The single compromise that I had to make is that the integration tests > >> > were not included in the reactor build and therefore not deployed to > >> > the nexus repo. Hopefully that's acceptable for the release. > >> > > >> > I can restart the release vote if needed ( third time's the charm? ) > >> > but it would be good to know that I got things right this time. > >> > > >> > Note: check_staged_release.sh took about 30 minutes to complete for > >>me. > >> > > >> > Thanks, > >> > > >> > Robert > >> > > >> > On Mon, Jun 30, 2014 at 1:53 PM, Carsten Ziegeler > >><cziege...@apache.org> > >> wrote: > >> >> Thanks for the info, Robert - I'm not sure what the best approach is, > >> >> however the zip now contains 1.0.0-SNAPSHOT as versions but I guess > >>the > >> >> final release should be 1.0.0. This would mean we're voting on > >>something > >> >> which is then not released. On the other hand, if we put up 1.0.0 in > >>a > >> >> globally available space everyone can simply download it from there > >>and > >> >> voting, especially withdrawing the release is way harder. > >> >> > >> >> Carsten > >> >> > >> >> > >> >> 2014-06-30 10:06 GMT+02:00 Robert Munteanu <romb...@apache.org>: > >> >> > >> >>> Hi Carsten, > >> >>> > >> >>> On Mon, Jun 30, 2014 at 8:57 AM, Carsten Ziegeler < > >> cziege...@apache.org> > >> >>> wrote: > >> >>> > Why is this release not following the normal release procedure and > >> >>> > available via the staging maven repo? > >> >>> > >> >>> There are two main reasons. > >> >>> > >> >>> 1. While the build is driven by Maven, building Eclipse plug-ins > >>with > >> >>> Tycho means that some of the regular Maven plugins don't work. For > >> >>> instance, the source and javadoc plugin, see [1],[2] . Since IIUC > >>the > >> >>> release is based on the source code, and the binaries are just for > >> >>> convenience, I opted not to make the release run on the output of > >> >>> individual projects, but on the whole source zip. > >> >>> > >> >>> 2. If I were to deploy the plug-ins by themselves to the repo, it > >> >>> would not be trivial to assemble back an p2/Eclipse update which can > >> >>> be used to test the functionality of the release. > >> >>> > >> >>> That being said, I'd be more than happy to refine this process, so > >> >>> suggestions on how to do that are welcome :-) > >> >>> > >> >>> Thanks, > >> >>> > >> >>> Robert > >> >>> > >> >>> > >> >>> [1]: https://dev.eclipse.org/mhonarc/lists/tycho-user/msg05730.html > >> >>> [2]: https://bugs.eclipse.org/bugs/show_bug.cgi?id=398061 > >> >>> > >> >>> > > >> >>> > Carsten > >> >>> > > >> >>> > > >> >>> > 2014-06-29 21:32 GMT+02:00 Robert Munteanu <romb...@apache.org>: > >> >>> > > >> >>> >> Anyone? > >> >>> >> > >> >>> >> Robert > >> >>> >> > >> >>> >> On Thu, Jun 26, 2014 at 11:32 AM, Robert Munteanu < > >> romb...@apache.org> > >> >>> >> wrote: > >> >>> >> > Hi, > >> >>> >> > > >> >>> >> > We solved 144 issues in this release: > >> >>> >> > > >> https://issues.apache.org/jira/browse/SLING/fixforversion/12324873 > >> >>> >> > > >> >>> >> > There are still some outstanding issues: > >> >>> >> > https://issues.apache.org/jira/browse/SLING/component/12320908 > >> >>> >> > > >> >>> >> > The release candidate has been uploaded at > >> >>> >> > https://dist.apache.org/repos/dist/dev/sling, > >> >>> >> > and can be built using > >> >>> >> > > >> >>> >> > mvn clean package > >> >>> >> > > >> >>> >> > The resulting binaries can be installed into an Eclipse > >>instance > >> by > >> >>> >> > installing from the update site which is found at > >> >>> >> > p2update/target/repository after building the project. > >> >>> >> > > >> >>> >> > Please vote to approve this release: > >> >>> >> > > >> >>> >> > [ ] +1 Approve the release > >> >>> >> > [ ] 0 Don't care > >> >>> >> > [ ] -1 Don't release, because ... > >> >>> >> > > >> >>> >> > This majority vote is open for at least 72 hours. > >> >>> >> > >> >>> > > >> >>> > > >> >>> > > >> >>> > -- > >> >>> > Carsten Ziegeler > >> >>> > Adobe Research Switzerland > >> >>> > cziege...@apache.org > >> >>> > >> >> > >> >> > >> >> > >> >> -- > >> >> Carsten Ziegeler > >> >> Adobe Research Switzerland > >> >> cziege...@apache.org > >> > > >> > > >> > > >> > -- > >> > Sent from my (old) computer > >> > > > > > > > >-- > >Carsten Ziegeler > >Adobe Research Switzerland > >cziege...@apache.org > > >
