[ 
https://issues.apache.org/jira/browse/SLING-4001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14182066#comment-14182066
 ] 

Sandro Boehme commented on SLING-4001:
--------------------------------------

++ Building without OSGi OBR deployment ++
I use the JSTL core and the JSTL functions TagLib with the Servlet 2.5 spec. I 
removed the Import-Package statement to test if I can install the Resource 
Editor but I don't get an error and it is not yet successful.
It looks like JSTL and Servlet 2.5 are already part of the Sling Launchpad v7. 
Then the build should generally work without an OSGi deployment by just using 
Maven. What command did you use to build the project and to get the error?

++ Is it needed to specify the Import-Packages manually? ++
I also think that the JSP scripting engine has access to the exported packages. 
There are people out there that use a modified version of the Launchpad right? 
By resolving the dependencies via OSGi they would still get all the 
dependencies that the Resource-Editor needs because they are specified in the 
pom right? If they wouldn't be specified I think these people would have a hard 
time getting the dependencies right.

++ Require-Bundle vs. embedding the JSNodeTypes library ++
What would be better then? The Require-Bundle isn't good practice but clean 
from an OSGi point of view and if there isn't a way to do that using 
import-package based dependencies then this might be one of the rare cases 
where the Require-Bundle makes sense. 

> Apache Sling Resource Editor contribution
> -----------------------------------------
>
>                 Key: SLING-4001
>                 URL: https://issues.apache.org/jira/browse/SLING-4001
>             Project: Sling
>          Issue Type: New Feature
>            Reporter: Sandro Boehme
>            Assignee: Bertrand Delacretaz
>         Attachments: apache _sling_resource_editor.zip
>
>
> Based on the discussion at the dev list [1, 2] I would like to contribute the 
> Apache Sling Resource Editor (previously named JCRBrowser and Apache Sling 
> Content Editor). 
> ++ Features ++
> Currently it can be used to rename and delete nodes. Rename works by double 
> clicking the node and you can multi select nodes for the deletion with the 
> 'del' key. The node names are HTML and URL escaped and it provides stateless 
> deep links to the nodes.
> ++ Further development ++
> In the months to come I can work more intensely on the Sling Resource Editor 
> and I might add commercial add-ons separately. This is why I would like to be 
> able to point users to such an add-on from Sling. But judging from other 
> Apache projects [6] I assume this is probably not a problem.
> I will continue the development at GitHub[7] and send patch files to Sling 
> when new features are implemented.
> ++ Implementation ++
> It uses the Sling API. 
> For the tree on the left the JSTree library is used. It expects a URL to a 
> JSON that contains the data for the child nodes. This URL points to a
> Sling resource with a 'reseditor.nodes' selector and a 'json' extension. This 
> way the JSPs [3] render the JSON for the resource that is consumed by the 
> JSTree library.
> For the deletion and renaming of nodes I use jQuery Ajax calls to the Sling 
> POST servlet. 
> The properties list on the right is rendered [4] using JSTL and the 
> currentNode variable of Sling.
> The html.jsp is registered for the 'reseditor' selector relatively to the 
> default servlet. And for not getting overruled by servlets registered by 
> paths and by other resources that are using the 'reseditor' selector I use a 
> ResourceDecorator [5]. 
> After a hint from Dominik Süß I work on using a ResourceProvider instead.
> I'm looking forward to your feedback! 
> [1] - http://comments.gmane.org/gmane.comp.apache.sling.devel/47292
> [2] - http://comments.gmane.org/gmane.comp.apache.sling.devel/47517
> [3] - 
> https://github.com/sandroboehme/resourceeditor/tree/master/src/main/resources/SLING-INF/libs/sling/servlet/default/reseditor
> [4] - 
> https://github.com/sandroboehme/resourceeditor/blob/master/src/main/resources/SLING-INF/libs/sling/servlet/default/reseditor/html.jsp
>  line 174
> [5] - 
> https://github.com/sandroboehme/resourceeditor/blob/master/src/main/java/org/apache/sling/reseditor/SelectorBasedResourceDecorator.java
> [6] - https://www.google.de/search?q=site%3Aapache.org+commercial 
> [7] - https://github.com/sandroboehme/resourceeditor



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to