[ 
https://issues.apache.org/jira/browse/SLING-4159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14208017#comment-14208017
 ] 

ASF GitHub Bot commented on SLING-4159:
---------------------------------------

GitHub user kwin opened a pull request:

    https://github.com/apache/sling/pull/35

    SLING-4159, close resource resolver in finally

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kwin/sling SLING-4159

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/sling/pull/35.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #35
    
----
commit 6824342763f82eb08ca074332b9a9687b55649ca
Author: Konrad Windszus <konrad.winds...@netcentric.biz>
Date:   2014-11-12T13:19:46Z

    SLING-4159, close resource resolver in finally

----


> Always close ResourceResolver in 
> ValidationServiceImpl.searchAndStoreValidationModel
> ------------------------------------------------------------------------------------
>
>                 Key: SLING-4159
>                 URL: https://issues.apache.org/jira/browse/SLING-4159
>             Project: Sling
>          Issue Type: Bug
>          Components: Validation
>            Reporter: Konrad Windszus
>            Priority: Minor
>
> Currently the resource resolver being opened in 
> {{ValidationServiceImpl.searchAndStoreValidationModel}} is only closed if no 
> RuntimeException is thrown. Generally resource resolvers should always be 
> closed within a {{finally}} block.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to