[ 
https://issues.apache.org/jira/browse/SLING-4155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14209804#comment-14209804
 ] 

Stefan Seifert commented on SLING-4155:
---------------------------------------

such a change on the annotations will indeed break both runtime and 
compile-time backward compatibility - we cannot do this unless we raise the 
version to v2.0.0 to comply to semantic versioning. i'm not sure if it's worth 
only for this issue, although i agree the current functionality is broken when 
injector-specific annotations are used.

for a first step we should document this issue (SLING-4156), and perhaps create 
a new version in JIRA to sling models 2.0.0 and collect there tickets like this 
so we do not forget it when time is ready for v2.

> DefaultInjectionStrategy not considered for injector-specific annotations
> -------------------------------------------------------------------------
>
>                 Key: SLING-4155
>                 URL: https://issues.apache.org/jira/browse/SLING-4155
>             Project: Sling
>          Issue Type: Bug
>          Components: Extensions
>    Affects Versions: Sling Models Implementation 1.0.6
>            Reporter: Konrad Windszus
>
> The default injection strategy (being implemented in SLING-3696) is only 
> considered, in case there is no injector-specific annotation being used.
> Otherwise it is just ignored.
> The logic should be like this:
> if annotationProcessor.isOptional() returns null
> -> the default injection strategy should be used
> in any other case the boolean value should be used.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to