[ 
https://issues.apache.org/jira/browse/SLING-4175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14222938#comment-14222938
 ] 

Konrad Windszus commented on SLING-4175:
----------------------------------------

Hi [~santiagozky],
that patch looks ok, but since a lot of refactoring of Sightly is currently 
oing on in a dedicated feature branch 
(http://www.mail-archive.com/dev%40sling.apache.org/msg39738.html) I will wait 
until the feature branch was merged back to trunk before applying this. Also I 
would like to hear some other opinions on this topic, because we have to be 
careful to not break backwards-compatibility with existing scripts.
For the future it would be great if the patches would not include any 
unintended changes (like newly inserted empty lines) and follow the general 
indentation of the file.

> Sightly: Do not catch exceptions in ResourceRuntimeExtension and 
> IncludeRuntimeExtension
> ----------------------------------------------------------------------------------------
>
>                 Key: SLING-4175
>                 URL: https://issues.apache.org/jira/browse/SLING-4175
>             Project: Sling
>          Issue Type: Bug
>          Components: Scripting
>            Reporter: Konrad Windszus
>              Labels: Sightly
>
> Currently all exceptions being thrown during the execution of 
> data-sly-include and data-sly-resource are caught and only logged.
> Instead those exceptions should be just wrapped (to ease debugging during 
> development) and also to be consistent with {{sling:call}} (SLING-3459).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to