[
https://issues.apache.org/jira/browse/SLING-4258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14278831#comment-14278831
]
Bertrand Delacretaz commented on SLING-4258:
--------------------------------------------
The pull request looks good but unfortunately there are no tests for
JsonObjectCreator in our current codebase, so I'm not keen on making changes to
that class before adding those tests. I suppose it's tested in integration
tests, up to a point, but local unit tests are much easier to verify.
I have started that in revision 1652140 with just a basic test, will expand it
and you can then adapt the result to your changes, in order to check that we
don't introduce unwanted changes.
> Please document better how dates are handled by the Post servlet
> ----------------------------------------------------------------
>
> Key: SLING-4258
> URL: https://issues.apache.org/jira/browse/SLING-4258
> Project: Sling
> Issue Type: Improvement
> Components: Documentation
> Reporter: santiago garcía pimentel
>
> Im currently doing some things with dates in Sling that involve timezones and
> I find that the documentation regarding it is not particularly clear.
> according to
> https://sling.apache.org/documentation/bundles/manipulating-content-the-slingpostservlet-servlets-post.html#date-properties
> several formats are defined.
> I found that the only format that saves a provided timezone is the ISO8601
> format, rest of them relies in a Date object, which does not have timezones.
> Could this be clearly stated?
> Also, the ISO8601 parser is problematic. It relies on the Jackrabbit parser
> which uses format "±YYYY-MM-DDThh:mm:ss.SSSTZD", but according to
> http://www.w3.org/TR/NOTE-datetime the ISO format does not have milliseconds
> on it ("SSS"). So it is very hard to find a way to keep the timezone
> information (I had to dig through the code to figure it out)
> Could we please replace ISO8601 with the actual format
> "±YYYY-MM-DDThh:mm:ss.SSSTZD" so it is clearer?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
